Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62867 )
Change subject: ichspi: Unify timeout (30sec) across all SPI operations ......................................................................
Patch Set 7: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62867/comment/f388a77c_82417d3c PS7, Line 7: Unify timeout (30sec) across all SPI operations `Unify timeouts across all SPI operations to 30s`
https://review.coreboot.org/c/flashrom/+/62867/comment/4f24dd8a_8c3f8b06 PS7, Line 9: This patch removes taking `timeout` argument for different operations : using `ich_hwseq_wait_for_cycle_complete()`. Make use of 30sec unified : timeout for all SPI operations. ``` Here we drop the `timeout` parameter from `ich_hwseq_wait_for_cycle_complete()` in favor of a fixed timeout of 30 seconds for any given SPI operation as recommended by the SPI programming guide: ```
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62867/comment/5c79e077_acebd202 PS7, Line 31: multi-master accessing the `multi-mastering access of the`
https://review.coreboot.org/c/flashrom/+/62867/comment/165d3c57_bb6ac915 PS7, Line 31: might `may`
https://review.coreboot.org/c/flashrom/+/62867/comment/5fe3cdab_8942fb41 PS7, Line 36: it's impossible to know : * the actual status of the SPI bus I thought that is the point of the `HSFS_SCIP` bit? The phrasing may need adjustment here to clarify the difference, ideally to mention how these two ingredients interplay with each other.