Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Angel Pons, Anastasia Klimchuk.

Patch set 7:Code-Review +1

View Change

5 comments:

• Commit Message:

  • Patch Set #7, Line 7: Unify timeout (30sec) across all SPI operations

    `Unify timeouts across all SPI operations to 30s`

  • Patch Set #7, Line 9:

    This patch removes taking `timeout` argument for different operations
    using `ich_hwseq_wait_for_cycle_complete()`. Make use of 30sec unified
    timeout for all SPI operations.
    

    ```
    Here we drop the `timeout` parameter from `ich_hwseq_wait_for_cycle_complete()` in favor of a fixed timeout of 30 seconds for any given SPI operation as recommended by the SPI programming guide:
    ```

• File ichspi.c:

  • Patch Set #7, Line 31: multi-master accessing the

    `multi-mastering access of the`

  • Patch Set #7, Line 31: might

    `may`

  • Patch Set #7, Line 36:

    it's impossible to know
     * the actual status of the SPI bus
    

    I thought that is the point of the `HSFS_SCIP` bit? The phrasing may need adjustment here to clarify the difference, ideally to mention how these two ingredients interplay with each other.

To view, visit change 62867. To unsubscribe, or for help writing mail filters, visit settings.