Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58623 )
Change subject: Makefile: Make pkg-config mandatory to find libftdi1 ......................................................................
Patch Set 8:
(1 comment)
File Makefile.include:
https://review.coreboot.org/c/flashrom/+/58623/comment/2182cb58_8d80a970 PS5, Line 40: 2>/dev/null
I think the terminal output of the Makefile should be enough in the end.
How? I mean it's about unexpected errors, not expected ones. So I don't think we'd want to clutter the Makefile just to provide accurate messages.
For instance, if anything goes wrong in `find_dependency` but lets make continue, we'd simply print that the dependency wasn't found. Ok, that's true, but doesn't tell us why it wasn't found. It could still be there. We'd at least have to also check if `pkg-config` is there, and if `pkg-config` can run (e.g. doesn't have trouble with shared libraries; I get that a lot on ArchLinux when installing something new without updating the whole system). Then, if pkg-config knows any error condi- tions, we'd have to relay that too?
OTOH, it's not very hard to keep the current behavior, e.g. just call `debug_shell` instead of `shell`?
-
Nico Huber (Code Review)