Attention is currently required from: Thomas Heijligen.

View Change

1 comment:

• File Makefile.include:

  • Patch Set #5, Line 40: 2>/dev/null

    I think the terminal output of the Makefile should be enough in the end.

    How? I mean it's about unexpected errors, not expected ones. So I don't
    think we'd want to clutter the Makefile just to provide accurate messages.

    For instance, if anything goes wrong in `find_dependency` but lets make
    continue, we'd simply print that the dependency wasn't found. Ok, that's
    true, but doesn't tell us why it wasn't found. It could still be there.
    We'd at least have to also check if `pkg-config` is there, and if
    `pkg-config` can run (e.g. doesn't have trouble with shared libraries;
    I get that a lot on ArchLinux when installing something new without
    updating the whole system). Then, if pkg-config knows any error condi-
    tions, we'd have to relay that too?

    OTOH, it's not very hard to keep the current behavior, e.g. just call
    `debug_shell` instead of `shell`?

To view, visit change 58623. To unsubscribe, or for help writing mail filters, visit settings.