[XL] Change in flashrom[master]: tree/: Convert flashchip probe func ptr to enumerate

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Nikolai Artemiev.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66781 )

Change subject: tree/: Convert flashchip probe func ptr to enumerate
......................................................................

Patch Set 7:

(2 comments)

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/66781/comment/bca72dc5_824a197c 
PS6, Line 732: default: total function
> Thanks for explanation about total function, question solved! […]

Done

File flashrom.c:

https://review.coreboot.org/c/flashrom/+/66781/comment/5981c6f6_62bebc92 
PS7, Line 712: static probe_func_t *lookup_probe_func_ptr(const struct flashchip *chip)
> Eventually we should change this so that instead of mapping enums to function pointers, we just have […]

This is along the same line of reasoning as Arthur, see above. One other issue is that in some case at the call sites the function pointer address is compared not dispatched.

I agree we should deal with all this as a follow on and get the conversion part done first.