Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Nikolai Artemiev.

View Change

2 comments:

• File flashrom.c:

  • Patch Set #6, Line 732: default: total function

    Thanks for explanation about total function, question solved! […]

    Done

• File flashrom.c:

  • Patch Set #7, Line 712: static probe_func_t *lookup_probe_func_ptr(const struct flashchip *chip)

    Eventually we should change this so that instead of mapping enums to function pointers, we just have […]

    This is along the same line of reasoning as Arthur, see above. One other issue is that in some case at the call sites the function pointer address is compared not dispatched.

    I agree we should deal with all this as a follow on and get the conversion part done first.

To view, visit change 66781. To unsubscribe, or for help writing mail filters, visit settings.