Attention is currently required from: Edward O'Callaghan. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59276 )
Change subject: pcidev: Move pci_get_dev() logic into canonical place ......................................................................
Patch Set 2:
(2 comments)
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/59276/comment/0471b29c_1a33d9a4 PS2, Line 162: OLD_PCI_GET_DEV Thomas already looked into this and the old version practically pre-dates libpci (as a library separate from pciutils). I asked to keep it until the next release. But given that this won't happen anytime soon, I wouldn't mind if we drop it right away.
File programmer.h:
https://review.coreboot.org/c/flashrom/+/59276/comment/0487862c_75d55356 PS2, Line 128: struct pci_dev *pcidev_getdev(struct pci_dev *dev); The signature makes it very obvious that we already have a dev. How about a more meaningful name, e.g. pcidev_clonedev()?