Attention is currently required from: Edward O'Callaghan.

View Change

2 comments:

• File pcidev.c:

  • Patch Set #2, Line 162: OLD_PCI_GET_DEV

    Thomas already looked into this and the old version practically pre-dates
    libpci (as a library separate from pciutils). I asked to keep it until the
    next release. But given that this won't happen anytime soon, I wouldn't
    mind if we drop it right away.

• File programmer.h:

  • Patch Set #2, Line 128: struct pci_dev *pcidev_getdev(struct pci_dev *dev);

    The signature makes it very obvious that we already have a dev. How
    about a more meaningful name, e.g. pcidev_clonedev()?

To view, visit change 59276. To unsubscribe, or for help writing mail filters, visit settings.