Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63488 )
Change subject: ich_descriptors_tool: Fix -Wsign-compare warnings ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63488/comment/4453919f_c8f1054b PS1, Line 10: and makefile. Please explain which warnings are fixed.
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/63488/comment/aae78d80_1d3e5983 PS1, Line 87: uint32_t I would prefer doing variable declarations at the beginning of the method, so that these are not scattered and one can find them easily.
Also, doesn't write() also return -1?
-
Felix Singer (Code Review)