Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 10: and makefile.

    Please explain which warnings are fixed.

• File util/ich_descriptors_tool/ich_descriptors_tool.c:

  • Patch Set #1, Line 87: uint32_t

    I would prefer doing variable declarations at the beginning of the method, so that these are not scattered and one can find them easily.

    Also, doesn't write() also return -1?

To view, visit change 63488. To unsubscribe, or for help writing mail filters, visit settings.