Attention is currently required from: Felix Singer, Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 6:
(2 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/06b83dba_722cbf22 PS4, Line 611: share/bash-completion/completions
Do you want me to add an option for `bash-completion/completions`?
Have a look at `https://github.com/swaywm/sway/blob/master/meson.build#L275%60 how they (swaywm) implemented the directory lookup. I think that is a good way.
File meson.build:
https://review.coreboot.org/c/flashrom/+/68247/comment/17ca35b4_1e0c8f27 PS6, Line 607: if get_option('bash_completion').auto() or get_option('bash_completion').enabled() If `classic_cli` is disabled and this is enabled it should give an error. See `config_print_wiki`
-
Thomas Heijligen (Code Review)