Attention is currently required from: Felix Singer, Anastasia Klimchuk, Alexander Goncharov.
View Change
2 comments:
File meson.build:
Patch Set #4, Line 611: share/bash-completion/completions
Do you want me to add an option for `bash-completion/completions`?
Have a look at `https://github.com/swaywm/sway/blob/master/meson.build#L275` how they (swaywm) implemented the directory lookup. I think that is a good way.
File meson.build:
Patch Set #6, Line 607: if get_option('bash_completion').auto() or get_option('bash_completion').enabled()
If `classic_cli` is disabled and this is enabled it should give an error. See `config_print_wiki`
To view, visit change 68247. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 6
Gerrit-Owner: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Wed, 12 Oct 2022 13:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment