[M] Change in flashrom[master]: flashrom.c: Add new erase_by_layout and walk_bylayout implementations
Attention is currently required from: Simon Buhrow, Thomas Heijligen, Edward O'Callaghan.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71173 )
Change subject: flashrom.c: Add new erase_by_layout and walk_bylayout implementations ......................................................................
Patch Set 7:
(10 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71173/comment/6d8cb69b_fe6db871 PS6, Line 1546: , erasefn_count);
`, count_usable_erasers(flashctx));`
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/b4f7fc54_3f03ff6d PS6, Line 1554: else
you don't need a `else`
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/62784027_458d98b6 PS6, Line 1681: int ret = 0;
if you use `ret = 1` as the default you exchange many `ret = 1`'s with one `ret = 0`.
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/8cef4076_3b2286e4 PS6, Line 1683: const struct romentry *entry = NULL;
pair with while loop construct.
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/9e2273d4_bb338fe5 PS6, Line 1684: struct erase_layout *erase_layout = create_erase_layout(flashctx);
If you can help it, pair with the branch below. […]
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/4b37bce1_e237c54d PS6, Line 1685: //no layout
delete
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/451f6e2f_dfdc0fd4 PS6, Line 1690: //erase layout creation failed
delete
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/10342f71_8b74252f PS6, Line 1701: erase_write(
line-wrap: […]
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/6f63b846_1295678c PS6, Line 1703: !!!
one `!` is sufficient or be consistent with the above and have none?
Done
https://review.coreboot.org/c/flashrom/+/71173/comment/773e0f5c_6c0f2226 PS6, Line 1718: else
ditto
Done
-
Aarya (Code Review)