Attention is currently required from: Simon Buhrow, Thomas Heijligen, Edward O'Callaghan.
10 comments:
File flashrom.c:
Patch Set #6, Line 1546: , erasefn_count);
`, count_usable_erasers(flashctx));`
Done
you don't need a `else`
Done
Patch Set #6, Line 1681: int ret = 0;
if you use `ret = 1` as the default you exchange many `ret = 1`'s with one `ret = 0`.
Done
Patch Set #6, Line 1683: const struct romentry *entry = NULL;
pair with while loop construct.
Done
Patch Set #6, Line 1684: struct erase_layout *erase_layout = create_erase_layout(flashctx);
If you can help it, pair with the branch below. […]
Done
Patch Set #6, Line 1685: //no layout
delete
Done
Patch Set #6, Line 1690: //erase layout creation failed
delete
Done
Patch Set #6, Line 1701: erase_write(
line-wrap: […]
Done
one `!` is sufficient or be consistent with the above and have none?
Done
ditto
Done
To view, visit change 71173. To unsubscribe, or for help writing mail filters, visit settings.