Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm ......................................................................
Patch Set 78:
(7 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/8575033a_37d2bac3 PS78, Line 720: <= len
what is happening here? Seems like its own change but not what the commit says "add wrapping functio […]
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/dafd29b8_48ef15fc PS78, Line 1374: size_t
`const uint32_t`, A `size_t` is a a system specific type.
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/449ff637_2c4e9e76 PS78, Line 1378: int
const
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/5d849711_4987f93a PS78, Line 1382: curcontents == NULL || newcontents == NULL
`!ptr` is canonical. Also `erase_layout` never checked.
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/0f99766f_180f5934 PS78, Line 1427: erase_layout
check for nullarity?
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/83a15b47_2d22b014 PS78, Line 1425: const struct flashrom_layout *const flash_layout = get_layout(flashctx); : const struct romentry *entry = NULL; : struct erase_layout *erase_layout = create_erase_layout(flashctx);
move below `erasefn_count` and `ret`
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/4071c242_88d11052 PS78, Line 1428: int
`const`
Done