Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.

7 comments:

File flashrom.c:
- Patch Set #78, Line 720: <= len
  what is happening here? Seems like its own change but not what the commit says "add wrapping functio […]
  Done
- Patch Set #78, Line 1374: size_t
  `const uint32_t`, A `size_t` is a a system specific type.
  Done
- Patch Set #78, Line 1378: int
  const
  Done
- Patch Set #78, Line 1382: curcontents == NULL || newcontents == NULL
  `!ptr` is canonical. Also `erase_layout` never checked.
  Done
- Patch Set #78, Line 1427: erase_layout
  check for nullarity?
  Done
- Patch Set #78, Line 1425:
```
	const struct flashrom_layout *const flash_layout = get_layout(flashctx);
	const struct romentry *entry = NULL;
	struct erase_layout *erase_layout = create_erase_layout(flashctx);
```
  move below `erasefn_count` and `ret`
  Done
- Patch Set #78, Line 1428: int
  `const`
  Done

To view, visit change 66104. To unsubscribe, or for help writing mail filters, visit settings.