Attention is currently required from: Aarya, Bill XIE, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email )
Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ......................................................................
Patch Set 9:
(3 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84721/comment/1f7af8a1_255511d3?usp... : PS8, Line 124: " --sacrifice-ratio <ratio> Maximum %% memory that is allowed for redundant\n"
This is understandable, but reads somewhat awkwardly to me. Perhaps: […]
And just right now, I realised manpage needs to be updated too!
Also would be good to add info into release_notes/devel.html. I actually think to copy the long commit message that I wrote :) It can go as is (only without "this patch adds")
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/84721/comment/514f3879_91d95a7f?usp... : PS8, Line 253: needless
needing?
That was actually the blocks that not needed to be erased, which was "needless". I did a modification to that comment text, to say directly that's `not needed to change`
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/84721/comment/4ee3e2e4_2e22d703?usp... : PS8, Line 1235: } : }, : sizeof(*all_cases) : ); : memcpy( : &all_cases[num_parameterized * 2 + 1], : (const struct CMUnitTest[]){ : (const struct CMUnitTest) { : .name = "write with sacrifice ratio 50", : .test_func = test_write_with_sacrifice_ratio50, : } : }, : sizeof(*all_cases) : );
The previous `memcpy` is already set up to copy an array of structs, so you can inline the new struc […]
Done