Attention is currently required from: Aarya, Bill XIE, Peter Marheine.

View Change

3 comments:

• File cli_classic.c:

  • Patch Set #8, Line 124: " --sacrifice-ratio <ratio> Maximum %% memory that is allowed for redundant\n"

    This is understandable, but reads somewhat awkwardly to me. Perhaps: […]

    And just right now, I realised manpage needs to be updated too!

    Also would be good to add info into release_notes/devel.html. I actually think to copy the long commit message that I wrote :) It can go as is (only without "this patch adds")

• File erasure_layout.c:

  • Patch Set #8, Line 253: needless

    needing?

    That was actually the blocks that not needed to be erased, which was "needless".
    I did a modification to that comment text, to say directly that's `not needed to change`

• File tests/erase_func_algo.c:

  • Patch Set #8, Line 1235:

    			}
    		},
    		sizeof(*all_cases)
    	);
    	memcpy(
    		&all_cases[num_parameterized * 2 + 1],
    		(const struct CMUnitTest[]){
    			(const struct CMUnitTest) {
    				.name = "write with sacrifice ratio 50",
    				.test_func = test_write_with_sacrifice_ratio50,
    			}
    		},
    		sizeof(*all_cases)
    	);
    

    The previous `memcpy` is already set up to copy an array of structs, so you can inline the new struc […]

    Done

To view, visit change 84721. To unsubscribe, or for help writing mail filters, visit settings.