Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62894 )
Change subject: ichspi: Rename HSFC FDBC offset macros
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62894/comment/5c8602c7_8a6b17a9
PS6, Line 10: during the data portion of the SPI cycle.
And only for `HSFC_FDBC -> HSFC_FDBC_MASK`, and not for the `_OFF` macro. `HSFC_FDBC_OFF` is the correct name anyway, and probably only changed to keep it pprint_reg() compatible.
It was me, I suggested to rename both HSFC_FDBC -> HSFC_FDBC_MASK and HSFC_FDBC_OFF -> HSFC_FDBC_MASK_OFF to be pprint_reg() compatible (in a comment earlier in this patch). I really like the idea of dropping _pprint_reg() macro, and I thought renaming both macros supported it.
But yes, not renaming any of them also is pprint_reg() compatible!
So, that means,
- this patch is not needed
- next patch CB:62892 becomes "Introduce HSFC_FDBC_VAL(n) macro" (instead of HSFC_FDBC(n) macro)
is this correct?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ae9a586b5c12f0229334898426175ec246a70c
Gerrit-Change-Number: 62894
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 00:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment