Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons.

View Change

1 comment:

• Commit Message:

  • Patch Set #6, Line 10: during the data portion of the SPI cycle.

    And only for `HSFC_FDBC -> HSFC_FDBC_MASK`, and not for the `_OFF` macro. `HSFC_FDBC_OFF` is the correct name anyway, and probably only changed to keep it pprint_reg() compatible.

    It was me, I suggested to rename both HSFC_FDBC -> HSFC_FDBC_MASK and HSFC_FDBC_OFF -> HSFC_FDBC_MASK_OFF to be pprint_reg() compatible (in a comment earlier in this patch). I really like the idea of dropping _pprint_reg() macro, and I thought renaming both macros supported it.

    But yes, not renaming any of them also is pprint_reg() compatible! So, that means,

    • this patch is not needed
    • next patch CB:62892 becomes "Introduce HSFC_FDBC_VAL(n) macro" (instead of HSFC_FDBC(n) macro)

    is this correct?

To view, visit change 62894. To unsubscribe, or for help writing mail filters, visit settings.