Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
Please split and thanks for the patience! […]
I split this into 5 patches, and first three are ready, these ones: https://review.coreboot.org/c/flashrom/+/52496 https://review.coreboot.org/c/flashrom/+/52497 https://review.coreboot.org/c/flashrom/+/52498
For the remaining two I still need to do testing and resolve comments. This patch is now #5 out of chain of 5.
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/9980bbe6_31ac8f23 PS2, Line 99: : 0));
This can get quite complex when additional tests are added. We can […]
Agree, this can happen (although I noticed for some cases it was sufficient to just return 0). But I am very happy that now all this is contained within tests/ directory which makes it easy to experiment and change. If tests pass means tests are not broken :)
-
Anastasia Klimchuk (Code Review)