Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    Please split and thanks for the patience! […]

    I split this into 5 patches, and first three are ready, these ones:
    https://review.coreboot.org/c/flashrom/+/52496
    https://review.coreboot.org/c/flashrom/+/52497
    https://review.coreboot.org/c/flashrom/+/52498

    For the remaining two I still need to do testing and resolve comments.
    This patch is now #5 out of chain of 5.

• File tests/tests.c:

  • Patch Set #2, Line 99: : 0));

    This can get quite complex when additional tests are added. We can […]

    Agree, this can happen (although I noticed for some cases it was sufficient to just return 0).
    But I am very happy that now all this is contained within tests/ directory which makes it easy to experiment and change. If tests pass means tests are not broken :)

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.