Attention is currently required from: Evan Benn.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72004 )
Change subject: flashrom_tester: Use Range and usize for all ranges ......................................................................
Patch Set 5:
(2 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/72004/comment/f87c31e2_d97abca6 PS5, Line 56: start,length It's confusing to describe this as `(start,length)` just because the range itself is using the usual Rust semantics (and it gets translated to the flashrom semantics behind the scenes).
Could just add some commentary here to that effect if you wanted to retain the information on how this maps to command line options, I guess.
https://review.coreboot.org/c/flashrom/+/72004/comment/65df7985_2f60552e PS5, Line 56: usize I think `u64` is more appropriate, since we don't really care how this relates to the system's pointer width and that still satisfies the goal of using an unsigned type.
-
Peter Marheine (Code Review)