Attention is currently required from: Evan Benn.

View Change

2 comments:

• File util/flashrom_tester/flashrom/src/cmd.rs:

  • Patch Set #5, Line 56: start,length

    It's confusing to describe this as `(start,length)` just because the range itself is using the usual Rust semantics (and it gets translated to the flashrom semantics behind the scenes).

    Could just add some commentary here to that effect if you wanted to retain the information on how this maps to command line options, I guess.

  • Patch Set #5, Line 56: usize

    I think `u64` is more appropriate, since we don't really care how this relates to the system's pointer width and that still satisfies the goal of using an unsigned type.

To view, visit change 72004. To unsubscribe, or for help writing mail filters, visit settings.