Attention is currently required from: Alan Green, Xiang Wang, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49637 )
Change subject: ft2232_spi.c: Generalize GPIOL pin control ......................................................................
Patch Set 8: Code-Review+1
(4 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49637/comment/d68939cb_21713728 PS5, Line 377: cs_bits
I think you're suggesting a change of variable name from cs_bits to pinlvl, right? […]
Yes, thanks!
https://review.coreboot.org/c/flashrom/+/49637/comment/845cdc90_9451d3ea PS5, Line 381:
Good point. […]
SGTM
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49637/comment/d529b564_13ef4746 PS8, Line 396: "Valid values are 4 character strings of H, L, Z " : "and X.\n" Please don't break user-visible strings. They can be as long as necessary.
https://review.coreboot.org/c/flashrom/+/49637/comment/2215c79d_4fe43a52 PS8, Line 402: "Example: gpiol=LZXH drives GPIOL 0 low, and GPIOL 3 " : "high, sets GPIOL 1\n" : "to an input and leaves GPIOL 2 in the default " : "state\n", arg); Ditto
-
Angel Pons (Code Review)