Attention is currently required from: Alan Green, Xiang Wang, Paul Menzel.

Patch set 8:Code-Review +1

View Change

4 comments:

• File ft2232_spi.c:

  • Patch Set #5, Line 377: cs_bits

    I think you're suggesting a change of variable name from cs_bits to pinlvl, right? […]

    Yes, thanks!

  • Patch Set #5, Line 381:

    Good point. […]

    SGTM

• File ft2232_spi.c:

  • Patch Set #8, Line 396:

     "Valid values are 4 character strings of H, L, Z "
    				 "and X.\n"
    

    Please don't break user-visible strings. They can be as long as necessary.

  • Patch Set #8, Line 402:

     "Example: gpiol=LZXH drives GPIOL 0 low, and GPIOL 3 "
    				 "high, sets GPIOL 1\n"
    				 "to an input and leaves GPIOL 2 in the default "
    				 "state\n", arg);
    

    Ditto

To view, visit change 49637. To unsubscribe, or for help writing mail filters, visit settings.