Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov.
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 6:
(4 comments)
Patchset:
PS6:
One more style nit I've noticed: we also place a space before the asterisk […]
Fixed.
PS6: Hi again Nico, here's a new round.
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/f61c20d8_3e06b7c1 PS5, Line 121: size_t num_xfer = (len + max_xfer_size - 1 ) / max_xfer_size; // ceil(len/max_xfer_size)
- Lift the `.max_data_*` limits so this function gets called for bigger […]
I've seen runs going a little bit faster (4 seconds instead of 6 seconds @ 1Mhz for a 2Mbit flash), but it's not really consistent enough to make any meaningful conclusion.
I think the main bottleneck lies in the size of the buffer we're able to send. Being able to max out USB bulk transfers would help a lot.
https://review.coreboot.org/c/flashrom/+/67878/comment/84fe2ccb_291e674b PS5, Line 267: }
Minor misunderstanding, I think. I meant this `if` block is all that […]
I removed the superfluous if conditions. I only added a check for the upper frequency bound, Frequency = 0 is no big deal, the adapter will use its lowest operating frequency. I added a check for the upper bound though, as it could be misleading to the user.
frequency renamed to spiseed.
-
Jean THOMAS (Code Review)