Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83969?usp=email )
Change subject: flashchips: Add definitions for Fudan FM25Q04, FM25Q64 and FM25Q128 ......................................................................
Patch Set 2:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83969/comment/79ecc99d_c6b1035b?usp... : PS2, Line 6203: /* 128 * 4KB sectors */ Just saying (for future), the comments for eraseblock definitions are not needed. You don't have to change it here, it's fine to keep here.
https://review.coreboot.org/c/flashrom/+/83969/comment/d0b62bac_001c9152?usp... : PS2, Line 6228: {2700, 3600} For Q04 and Q64, datasheet says 2.3-3.6V, is there a reason why you put 2.7-3.6 here?
(for Q128, it is indeed 2.7-3.6V)