Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
View Change
2 comments:
File flashchips.c:
Patch Set #2, Line 6203: /* 128 * 4KB sectors */
Just saying (for future), the comments for eraseblock definitions are not needed.
You don't have to change it here, it's fine to keep here.
Patch Set #2, Line 6228: {2700, 3600}
For Q04 and Q64, datasheet says 2.3-3.6V, is there a reason why you put 2.7-3.6 here?
(for Q128, it is indeed 2.7-3.6V)
To view, visit change 83969. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I88fcc2bbb9706c8adb3722da6aa0e1d2d04c3fde
Gerrit-Change-Number: 83969
Gerrit-PatchSet: 2
Gerrit-Owner: Samantaz Fox <coding@samantaz.fr>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Samantaz Fox <coding@samantaz.fr>
Gerrit-Comment-Date: Thu, 22 Aug 2024 08:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No