Attention is currently required from: Daniel Campello, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60069 )
Change subject: flashrom.c: Make {read,write}_buf_from_include_args() public ......................................................................
Patch Set 3:
(1 comment)
File flash.h:
https://review.coreboot.org/c/flashrom/+/60069/comment/45232048_dd075efe PS3, Line 353: read_buf_from_include_args
There are few existing include_args functions in layout.h. […]
It's a good idea in theory but read_buf_from_file() [sic. write_buf_to_file()] is used in many places in flashrom.c I think breaking up flashrom.c a bit is another orthogonal task to lifting cli upon libflashrom.
One plausible thing to do here is to expose {read,write}_buf_{from,to}_file() symbols here and then move said functions to layout however that leads to more lines and bigger headers. It would seem a bit half done if that line of thinking wasn't continued to the logical end point of breaking up flashrom.c so it wasn't so big.