Attention is currently required from: Daniel Campello, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File flash.h:

  • Patch Set #3, Line 353: read_buf_from_include_args

    There are few existing include_args functions in layout.h. […]

    It's a good idea in theory but read_buf_from_file() [sic. write_buf_to_file()] is used in many places in flashrom.c I think breaking up flashrom.c a bit is another orthogonal task to lifting cli upon libflashrom.

    One plausible thing to do here is to expose {read,write}_buf_{from,to}_file() symbols here and then move said functions to layout however that leads to more lines and bigger headers. It would seem a bit half done if that line of thinking wasn't continued to the logical end point of breaking up flashrom.c so it wasn't so big.

To view, visit change 60069. To unsubscribe, or for help writing mail filters, visit settings.