Change in flashrom[master]: tests: Remove mock struct pci_dev, use real pci symbols in tests - flashrom-gerrit

22 Mar 2022


      Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62948 )
Change subject: tests: Remove mock struct pci_dev, use real pci symbols in tests
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Nit: For the future: can we have standalone mock headers for usb, pci, hwaccess, ... […]
Yes! It came up in the conversations earlier, this is definitely option. And it always remains an option that we can decide and implement at any time. Technically "at any time", practically "at any time when someone has time" :)
Out of the headers you listed, hwaccess is already mocked for tests: 
 tests/hwaccess_x86_io_unittest.h
which is included in flashrom_test_dep (line number at the time of writing this)
 meson.build#L522
So we know it is definitely a working solution, to have mock header for tests.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1206fbdca392f190066a364376ce0db28071e53c
Gerrit-Change-Number: 62948
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 04:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment