Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan.
1 comment:
Patchset:
Nit: For the future: can we have standalone mock headers for usb, pci, hwaccess, ... […]
Yes! It came up in the conversations earlier, this is definitely option. And it always remains an option that we can decide and implement at any time. Technically "at any time", practically "at any time when someone has time" :)
Out of the headers you listed, hwaccess is already mocked for tests:
tests/hwaccess_x86_io_unittest.h
which is included in flashrom_test_dep (line number at the time of writing this)
meson.build#L522
So we know it is definitely a working solution, to have mock header for tests.
To view, visit change 62948. To unsubscribe, or for help writing mail filters, visit settings.