Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev.
Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82175?usp=email )
Change subject: flashrom: Change chip unlock error to warning ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/82175/comment/761dd0eb_731e6fcf : PS1, Line 10: and flashrom doesn't treat it as such
Just wanted to check: does flashrom never treat it as an error, or does it depend on flags?
it's never treated as an error. there is some fallback behavior involved, but it's not conditional on the flags in question.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/82175/comment/c6395ab8_26a33dd7 : PS1, Line 2134: ret to help answer Anastasia's question: this is the only place `unlock_flash_wp()`'s return code is checked.