Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev.
Patch set 1:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #1, Line 10: and flashrom doesn't treat it as such
Just wanted to check: does flashrom never treat it as an error, or does it depend on flags?
it's never treated as an error. there is some fallback behavior involved, but it's not conditional on the flags in question.
File flashrom.c:
Patch Set #1, Line 2134: ret
to help answer Anastasia's question: this is the only place `unlock_flash_wp()`'s return code is checked.
To view, visit change 82175. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I14c3b55e387443909ca1efab2fc1901f87dd66d6
Gerrit-Change-Number: 82175
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Mon, 06 May 2024 19:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment