Attention is currently required from: Nico Huber, Michał Żygowski, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API ......................................................................
Patch Set 6:
(2 comments)
File acpi_ec.c:
https://review.coreboot.org/c/flashrom/+/55714/comment/acf1edb5_084e2674 PS6, Line 43: EC_MAX_STATUS_CHECKS
If this is the default, why is it also part of the API?
Personally, I wouldn't provide a default value for `max_checks`. I feel it's simpler to have API users specify the value they want to use.
https://review.coreboot.org/c/flashrom/+/55714/comment/31421539_7c4bb267 PS6, Line 48: }
Would you mind exchanging the conditions? It seems odd not to check the […]
+1. Same applies to `ec_wait_for_obuf()`
-
Angel Pons (Code Review)