Attention is currently required from: Nico Huber, Michał Żygowski, Michael Niewöhner.

View Change

2 comments:

• File acpi_ec.c:

  • Patch Set #6, Line 43: EC_MAX_STATUS_CHECKS

    If this is the default, why is it also part of the API?

    Personally, I wouldn't provide a default value for `max_checks`. I feel it's simpler to have API users specify the value they want to use.

  • Patch Set #6, Line 48: }

    Would you mind exchanging the conditions? It seems odd not to check the […]

    +1. Same applies to `ec_wait_for_obuf()`

To view, visit change 55714. To unsubscribe, or for help writing mail filters, visit settings.