Change in flashrom[master]: libflashrom,writeprotect: add flashrom_wp_{read,write}_chip_config()
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add flashrom_wp_{read,write}_chip_config() ......................................................................
Patch Set 13:
(5 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/ac4bbb05_a11eb75b PS11, Line 4: 2010
It is 2021 now, you are adding the lines in 2021
The `enum flashrom_wp_mode` definition and comments came from the 2010 file. I'll check what this should be.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/76cdc8e6_b033381a PS9, Line 128: return ret;
But it is still the same, you haven't changed the code? […]
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/78812e62_1388f64b PS9, Line 161: ord = cfga->cmp - cfgb->cmp;
You forgot :)
Oops, I changed it but as part of a later CL :)
I've moved it back to this one now
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/02c34c71_7be199fa PS11, Line 51: cfg
Should be "param".
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/9cbea18b_58e43d78 PS11, Line 145: * @cfg[in] cfga The first configuration to compare. : * @cfg[in] cfgb The second configuration to compare.
"@cfg" -> "@param"
Done
-
Nikolai Artemiev (Code Review)