Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.

View Change

5 comments:

• File libflashrom.h:

  • Patch Set #11, Line 4: 2010

    It is 2021 now, you are adding the lines in 2021

    The `enum flashrom_wp_mode` definition and comments came from the 2010 file. I'll check what this should be.

• File writeprotect.c:

  • Patch Set #9, Line 128: return ret;

    But it is still the same, you haven't changed the code? […]

    Done

  • Patch Set #9, Line 161: ord = cfga->cmp - cfgb->cmp;

    You forgot :)

    Oops, I changed it but as part of a later CL :)

    I've moved it back to this one now

• File writeprotect.c:

  • Patch Set #11, Line 51: cfg

    Should be "param".

    Done

  • Patch Set #11, Line 145:

    * @cfg[in] cfga The first configuration to compare.
     * @cfg[in] cfgb The second configuration to compare.
    

    "@cfg" -> "@param"

    Done

To view, visit change 58479. To unsubscribe, or for help writing mail filters, visit settings.