Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 )
Change subject: meson: add option to disable tests ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63832/comment/d38c8be5_5e8e6a67 PS1, Line 10: Run `meson -Dtests=true` to enable tests. (default) : Run `meson -Dtests=false` to disable tests.
I've updated the commit message. Now it should be mode clear what happen. […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/63832/comment/e3d3fce5_c0c2964d PS4, Line 10: musst musst -> must (typo)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63832/comment/f3dd066b_8e81e81a PS1, Line 522: if cmocka_dep.found()
cmocka is now a required dependency for tests. Therefore the `if cmocka_dep. […]
I found what I was remembering, this commit 16c62a791d0a311bb040812b03c33881ab641a8e
That was handling of the case when tests are enabled but libcmocka not available: in this case flashrom will still build just without tests. We need to keep this behaviour.
-
Anastasia Klimchuk (Code Review)