Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 10:

    Run `meson -Dtests=true` to enable tests. (default)
    Run `meson -Dtests=false` to disable tests.
    

    I've updated the commit message. Now it should be mode clear what happen. […]

    Done

• Commit Message:

  • Patch Set #4, Line 10: musst

    musst -> must (typo)

• File meson.build:

  • Patch Set #1, Line 522: if cmocka_dep.found()

    cmocka is now a required dependency for tests. Therefore the `if cmocka_dep. […]

    I found what I was remembering, this commit 16c62a791d0a311bb040812b03c33881ab641a8e

    That was handling of the case when tests are enabled but libcmocka not available: in this case flashrom will still build just without tests.
    We need to keep this behaviour.

To view, visit change 63832. To unsubscribe, or for help writing mail filters, visit settings.