[S] Change in flashrom[main]: Extract SPI declarations to the correct header - flashrom-gerrit

9 Dec 2024


      Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco.
Matti Finder has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email )
Change subject: Extract SPI declarations to the correct header
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed.
This is probably also the case in edi.c and also a lot of other files within flashrom. I think changing them within this commit would make sense, so that this doesn't get missed later.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/85539?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0
Gerrit-Change-Number: 85539
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Vázquez Blanco antoniovazquezblanco@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Matti Finder matti.finder@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Antonio Vázquez Blanco antoniovazquezblanco@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 09 Dec 2024 13:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No