Attention is currently required from: Anastasia Klimchuk, Antonio Vázquez Blanco.
View Change
1 comment:
Patchset:
Patch Set #1:
Since you moved spi_send_command to spi.h the `#include "flash.h"` from rpmc.c can be removed.
This is probably also the case in edi.c and also a lot of other files within flashrom. I think changing them within this commit would make sense, so that this doesn't get missed later.
To view, visit change 85539. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0
Gerrit-Change-Number: 85539
Gerrit-PatchSet: 1
Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Matti Finder <matti.finder@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 09 Dec 2024 13:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No