Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58738 )
Change subject: cli_classic: add writeprotect CLI ......................................................................
Patch Set 12:
(2 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/58738/comment/ad9b1b25_951130f6 PS12, Line 190: wp_cli I remember there was a conversation about cli vs libflashrom in some other patch in this chain, I have a question in that context: Is `wp_cli` going to live inside cli_classic, it is it just temporarily? Can this be called from libflashrom? There is some logic in here, it would be great not to repeat the same for libflashrom calls?
I understand that parsing command line arguments is cli specific, but it seems like at the point of calling `wp_cli` the parsing done?
https://review.coreboot.org/c/flashrom/+/58738/comment/6647ccc7_a029f11a PS12, Line 890: ret = wp_cli( : fill_flash, : enable_wp, : disable_wp, : print_wp_status, : print_available_ranges, : set_wp_range, : wp_start, : wp_len, : wp_mode_opt : ); Does this fit into 112 chars? If yes let's have it one line?