Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk.

View Change

2 comments:

• File cli_classic.c:

  • Patch Set #12, Line 190: wp_cli

    I remember there was a conversation about cli vs libflashrom in some other patch in this chain, I have a question in that context:
    Is `wp_cli` going to live inside cli_classic, it is it just temporarily? Can this be called from libflashrom?
    There is some logic in here, it would be great not to repeat the same for libflashrom calls?

    I understand that parsing command line arguments is cli specific, but it seems like at the point of calling `wp_cli` the parsing done?

  • Patch Set #12, Line 890:

    ret = wp_cli(
    			fill_flash,
    			enable_wp,
    			disable_wp,
    			print_wp_status,
    			print_available_ranges,
    			set_wp_range,
    			wp_start,
    			wp_len,
    			wp_mode_opt
    		);
    

    Does this fit into 112 chars? If yes let's have it one line?

To view, visit change 58738. To unsubscribe, or for help writing mail filters, visit settings.