Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59529 )
Change subject: spi25_statusreg: delete read_status_register() ......................................................................
Patch Set 6:
(3 comments)
File it87spi.c:
https://review.coreboot.org/c/flashrom/+/59529/comment/7fd84c15_ca22204d PS4, Line 136: while (true)
I am curious, can this ever become an infinite loop? I understand it was like this before ;)
It can, though without knowing more about the programmer I'm not sure what a reasonable timeout would be. Probably safest to leave it for now but I'll add a comment.
https://review.coreboot.org/c/flashrom/+/59529/comment/e5f86707_0a190c6c PS4, Line 139: return 1;
Can we propagate error code from spi_read_register?
Done
https://review.coreboot.org/c/flashrom/+/59529/comment/73388e5e_65903566 PS4, Line 288: return 1;
Looks like another opportunity to propagate error code!
Done
-
Nikolai Artemiev (Code Review)