Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

3 comments:

• File it87spi.c:

  • Patch Set #4, Line 136: while (true)

    I am curious, can this ever become an infinite loop? I understand it was like this before ;)

    It can, though without knowing more about the programmer I'm not sure what a reasonable timeout would be. Probably safest to leave it for now but I'll add a comment.

  • Patch Set #4, Line 139: return 1;

    Can we propagate error code from spi_read_register?

    Done

  • Patch Set #4, Line 288: return 1;

    Looks like another opportunity to propagate error code!

    Done

To view, visit change 59529. To unsubscribe, or for help writing mail filters, visit settings.