Change in flashrom[master]: meson.build: Use 'std=c17'

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

HAOUAS Elyes (Code Review)

5 Aug 2020 5 Aug '20

6:40 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/44197 )

Change subject: meson.build: Use 'std=c17' ......................................................................

meson.build: Use 'std=c17'

Currently, C17 is used as no C language dialect options are given. So meson should use the same.

Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/44197/1

diff --git a/meson.build b/meson.build index 04176f3..7675a34 100644 --- a/meson.build +++ b/meson.build @@ -2,7 +2,7 @@ version : run_command('util/getversion.sh', '-v').stdout().strip(), license : 'GPL-2.0', meson_version : '>=0.47.0', - default_options : ['warning_level=2', 'c_std=c99'], + default_options : ['warning_level=2', 'c_std=c17'], )

# libtool versioning

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Angel Pons (Code Review)

6 Aug 6 Aug

11:21 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44197 )

Change subject: meson.build: Use 'std=c17' ......................................................................

Patch Set 1: Code-Review-1

AFAIUI, GCC by default uses *gnu17* according to the documentation: https://gcc.gnu.org/onlinedocs/gcc/Standards.html

The default, if no C language dialect options are given, is -std=gnu17.

Plus, not everyone is using the latest GCC to compile flashrom.

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Aug 2020 11:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7 Aug 7 Aug

1 p.m.

Hello build bot (Jenkins), Nico Huber, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/44197

to look at the new patch set (#2).

Change subject: meson.build: Use 'std=c17' ......................................................................

meson.build: Use 'std=c17'

Currently, gnu17 is used as no C language dialect options are given. So meson should use the same.

Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/44197/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1 p.m.

Hello build bot (Jenkins), Nico Huber, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/44197

to look at the new patch set (#3).

Change subject: meson.build: Use 'std=c17' ......................................................................

meson.build: Use 'std=c17'

Currently, gnu17 is used as no C language dialect options are given. So meson should use the same.

Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/44197/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1:01 p.m.

New subject: Change in flashrom[master]: meson.build: Use 'std=gnu17'

Hello build bot (Jenkins), Nico Huber, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/44197

to look at the new patch set (#4).

Change subject: meson.build: Use 'std=gnu17' ......................................................................

meson.build: Use 'std=gnu17'

Currently, gnu17 is used as no C language dialect options are given. So meson should use the same.

Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/44197/4

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

8 Aug 8 Aug

8:29 p.m.

New subject: Change in flashrom[master]: meson.build: Use 'std=gnu17'

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44197 )

Change subject: meson.build: Use 'std=gnu17' ......................................................................

Patch Set 4:

...

Patch Set 1: Code-Review-1

AFAIUI, GCC by default uses *gnu17* according to the documentation: https://gcc.gnu.org/onlinedocs/gcc/Standards.html

The default, if no C language dialect options are given, is -std=gnu17.

Plus, not everyone is using the latest GCC to compile flashrom.

Why not just remove the specified C standard? The official build system (Makefile) does not seem to set it.

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Aug 2020 20:29:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10 Aug 10 Aug

11:31 a.m.

New subject: Change in flashrom[master]: meson.build: Use 'std=gnu17'

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44197 )

Change subject: meson.build: Use 'std=gnu17' ......................................................................

Patch Set 4:

...

Patch Set 4:

...
Patch Set 1: Code-Review-1

AFAIUI, GCC by default uses *gnu17* according to the documentation: https://gcc.gnu.org/onlinedocs/gcc/Standards.html

The default, if no C language dialect options are given, is -std=gnu17.

Plus, not everyone is using the latest GCC to compile flashrom.

Why not just remove the specified C standard? The official build system (Makefile) does not seem to set it.

done

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 11:31:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11 Aug 11 Aug

10:46 p.m.

New subject: Change in flashrom[master]: meson.build: Use 'std=gnu17'

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/44197 )

Change subject: meson.build: Use 'std=gnu17' ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/flashrom/+/44197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409 Gerrit-Change-Number: 44197 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1593

days inactive

1599

days old

flashrom-gerrit@flashrom.org

7 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)