Patch Set 4:

Patch Set 1: Code-Review-1

AFAIUI, GCC by default uses *gnu17* according to the documentation:

 The default, if no C language dialect options are given, is -std=gnu17.

Plus, not everyone is using the latest GCC to compile flashrom.

Why not just remove the specified C standard? The official build system (Makefile) does not seem to set it.


View Change

To view, visit change 44197. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id47c840c2ef24e57917ccd74e86418e700e6e409
Gerrit-Change-Number: 44197
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Mon, 10 Aug 2020 11:31:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment