Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58482 )
Change subject: libflashrom,writeprotect: add flashrom_wp_set_range()
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS6:
+1 to getting the right abstraction from the beginning, libflashrom entry-points is certainly that w […]
Thanks Nico and Edward for the points above. I've gone through the writeprotect code and deleted anything that assumed it was being called from a CLI environment, i.e. it doesn't print any errors to stderr now.
That also required breaking up some functions into smaller operations, which I think is generally better. All writeprotect functions are now exposed through libflashrom.h.
As for splitting off a new CLI binary, I've factored out most of the WP related CLI code into a separate function (wp_cli() in review.coreboot.org/c/flashrom/+/58738/3), so it will be pretty easy to move everything. For now though maybe we can leave it in cli_classic while we finish off the core WP functionality?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7d26f43fb05c5828b9839bb57a28fa1088dcd9a0
Gerrit-Change-Number: 58482
Gerrit-PatchSet: 9
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 11 Nov 2021 11:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment